Support for using honggfuzz with gcc#263
Support for using honggfuzz with gcc#263simonresch wants to merge 3 commits intobazel-contrib:mainfrom
Conversation
Using the latest mast commit since releases are very infrequent.
Co-authored-by: Simon Resch <simon.resch@code-intelligence.de>
simonresch
requested review from
asraa,
fniksic,
inferno-chromium,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
|
Ping @stefanbucur. Is there any interest in adding this? |
Adds the flag --@rules_fuzzing//fuzzing:compiler_type with possible configurations "cmake" and "gcc". This allows running honggfuzz with a gcc toolchain which can be useful for code bases that don't compile with clang or where no clang toolchain is available. Co-authored-by: Markus Zoppelt <markus.zoppelt@code-intelligence.com>
| ) | ||
|
|
||
| config_setting( | ||
| name = "is_gcc", |
There was a problem hiding this comment.
This could be replaced with the predefined settings in @rules_cc//cc/compiler. Then we don't need compiler_type at all as the choice will be determined by the C++ toolchain.
There was a problem hiding this comment.
I originally attempted something based on @rules_cc//cc/compiler but got stuck on this error
ERROR: .../rules_fuzzing/examples/java/BUILD:31:15: On dependency edge //examples/java:EmptyFuzzTest_bin (3b35bd8) -|binary|-> //examples/java:EmptyFuzzTest_raw_: attempting to transition on '@@rules_cc+//cc/compiler:gcc' which is not a build setting
when adding @rules_cc//cc/compiler:gcc as an input to the fuzzing_binary_transition transition. Do you have an idea how to access the compiler type from the transition without it being an explicit flag?
There was a problem hiding this comment.
I followed up on bazelbuild/rules_cc#435. If we had that, we could read the compiler from an implicit attribute of the fuzzing_binary rule.
Let's wait for a few days before we look into alternatives.
There was a problem hiding this comment.
It's in now, we would just need to update rules_cc.
There was a problem hiding this comment.
I'm still getting the error after updating rules_cc to 0.2.17:
ERROR: /home/simon/git/rules_fuzzing/examples/BUILD:111:13: On dependency edge //examples:re2_fuzz_test_bin (508b23e) -|binary|-> //examples:re2_fuzz_test_raw_: attempting to transition on '@@rules_cc+//cc/compiler:compiler' which is not a build setting`
Any idea how to get the compiler setting to work in a transition? Would it need to be a build_setting?
There was a problem hiding this comment.
I think I have something that works, but I'm running into unrelated issues with the rules_cc update (stardoc targets are painful). I'll take another look tomorrow.
fmeum
removed request for
asraa,
fniksic,
inferno-chromium,
oliverchang,
stefanbucur and
xinhaoyuan
3 participants
Adds the flag
--@rules_fuzzing//fuzzing:compiler_typewith possible configurationscmakeandgcc. This allows running honggfuzz with a gcc toolchain which can be useful for code bases that don't compile with clang or where no clang toolchain is available.Example usage:
Invalid engine / compiler combination: